Skip to content

Prevent exceptions from interrupting controller messenger event processing #566

Closed
Closed
Prevent exceptions from interrupting controller messenger event processing#566
Labels
enhancementNew feature or request

Description

@rekmarks
rekmarks
opened on Aug 22, 2021

Currently, if a controller messenger event handler or selector throws, processing will be interrupted, and none of the subsequent handlers will be called. We should ensure that all event handlers are always called, ala safe-event-emitter.

Activity

  1. Gudahtt
    added
    enhancementNew feature or request
    on Nov 4, 2021

  2. Gudahtt commented on Nov 4, 2021

    @Gudahtt
    Gudahtt
    on Nov 4, 2021
    Member

    @rekmarks Considering the latest comments on #567, do you think we can close this? As far as I can see, the way this works right now is pretty reasonable. We can instead ensure that we fix any instances of crashing handlers that we find.

  3. Gudahtt commented on Mar 10, 2022

    @Gudahtt
    Gudahtt
    on Mar 10, 2022
    Member

    Closing for reasons mentioned in last comment. Can re-open if we discover otherwise.

  4. Gudahtt
    closed this as completedon Mar 10, 2022
  5. amitabh94
    added a commit that references this issue on Jun 16, 2026

    feat: Log the original transaction status (MetaMask#566)

    8fe2a77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions