Ensure that all controllers used across clients are using BaseControllerV2

[mcmire]

These controllers are still using BaseController (v1) and need to be migrated to BaseControllerV2. Some controllers don't need to be controllers at all.

Core packages

• Message managers (perhaps these need to be called "*Controller"?) (https://github.com/MetaMask/MetaMask-planning/issues/1930 — Confirmations team handling)
  • AbstractMessageManager
  • PersonalMessageManager
  • DecryptMessageManager
  • EncryptionPublicKeyManager
  • MessageManager
  • PersonalMessageManager
  • TypedMessageManager
• AddressBookController (Convert AddressBookController from BaseControllerV1 to BaseControllerV2 #4070)
• AccountTrackerController (Convert AccountTrackerController from BaseControllerV1 to BaseControllerV2 #4071)
• AnnouncementController (AnnouncementController migration to BaseControllerV2 #959)
• ApprovalController (Migrate ApprovalController to BaseControllerV2 #555)
• AssetsContractController (Convert AssetsContractController from BaseControllerV1 to BaseControllerV2 #4072)
• KeyringController (Migrate KeyringController to BaseControllerV2 #1378)
• NetworkController (Refactor NetworkController to BaseControllerV2 #903)
• NftController (Convert NftController from BaseControllerV1 to BaseControllerV2 #4073)
• NftDetectionController (Convert NftDetectionController from BaseControllerV1 to BaseControllerV2 #4074)
• TokenBalancesController (Update TokenBalancesController to BaseControllerV2 #1808)
• TokenDetectionController (Upgrade TokenDetectionController to BaseControllerV2 #3625)
• TokenRatesController (Convert TokenRatesController from BaseControllerV1 to BaseControllerV2 #4076)
• TokensController (Convert TokensController from BaseControllerV1 to BaseControllerV2 #4075)
• ComposableController (Update ComposableController to BaseController v2 #2082)
• PhishingController (Migrate PhishingController to BaseControllerV2 #1705)
• PreferencesController (Upgrade PreferencesController to BaseControllerV2 #3708)
• TransactionController (Upgrade TransactionController to BaseControllerV2 #3758)

Non-core packages

• MetaMask/smart-transactions-controller
• MetaMask/swaps-controller

Extension controllers

• AccountTrackerController (Convert AccountTracker (implementation + tests) to TypeScript metamask-extension#25928, Migrate AccountTrackerController to BaseController v2 metamask-extension#25929)
• AlertController (Convert AlertController to TypeScript metamask-extension#25921, Migrate AlertController to BaseController v2 metamask-extension#25915)
• AppStateController (Convert AppStateController (implementation + tests) to TypeScript metamask-extension#25922, Migrate AppStateController to BaseController v2 metamask-extension#25916)
• MetaMetricsController (Convert MetaMetricsController (implementation + tests) to TypeScript metamask-extension#25924, Migrate MetaMetricsController to BaseController v2 metamask-extension#25925)
• MMIController (Convert MMIController to a non-controller (without renaming it) metamask-extension#25926)
• OnboardingController (Migrate OnboardingController to BaseController v2 metamask-extension#25927)
• PreferencesController (Convert PreferencesController (implementation & tests) to TypeScript metamask-extension#25923, Migrate PreferencesController to BaseController v2 metamask-extension#25917)
• SwapsController (chore: refactor SwapsController so it extends from BaseControllerV2 metamask-extension#25681)
• AppMetadataController (Migrate AppMetadataController to BaseControllerV2 metamask-extension#28467)

[MajorLift]

These also need to be updated:

• external:
  • SmartTransactionsController
  • SwapsController

Completed:

• core:
  • AnnouncementController: AnnouncementController migration to BaseControllerV2 #959
  • ApprovalController: Migrate ApprovalController to BaseControllerV2 #555
  • KeyringController: Migrate KeyringController to BaseControllerV2 #1378
  • NetworkController: Refactor NetworkController to BaseControllerV2 #903
  • PhishingController: Migrate PhishingController to BaseControllerV2 #1705

[MajorLift]

@desi @mcmire Could we convert this into an epic? I think it would be helpful keep track of our progress on these upgrades, especially since some of them are prerequisites for work currently being done on controllers by us (#1780) and DevEx, Confirmations etc.

[mcmire]

@MajorLift Done!

[desi]

We have one additional controller that needs to be updated. AppMetadataController. Adding it to the check list.

[mcmire]

We were waiting on the MMIController to be removed from extension, but we don't have to migrate that anyway. So we're done!