Conversation
ccharly
marked this pull request as ready for review
September 23, 2026 09:48
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 321066f. Configure here.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Changes how accounts are removed across keyrings and snaps, including partial-failure semantics and SnapKeyring’s “local remove first” behavior, which can desync wallet state from snap state if remote deletion fails.
Overview
Adds bulk account deletion to the v2 keyring surface:
deleteAccounts(accountIds)on theKeyringinterface, thekeyring_deleteAccountsRPC (params{ ids }), andDeleteAccountsErrorwith a per-accountfailuresmap when any deletion fails after a best-effort pass.KeyringWrappernow treatsdeleteAccountsas the primitive implementation and provides a defaultdeleteAccountthat calls it with a single ID; Ethereum keyring adapters implement bulk delete withPromise.allSettledplustoAccountsFailures/toErrorMessagefromkeyring-utils. HD deletes in descending derivation order so only “last account” rules still apply during multi-delete.The snap path wires
KeyringClient.deleteAccounts, an RPC handler, andDeleteAccountsSnapErrorfor structured snap failures.SnapKeyringclears the local registry first (same as single delete), calls bulk RPC for v2 snaps, and falls back to per-account RPC for v1; snap-side errors are logged, not thrown. MoneyKeyring keeps deletion unsupported via a no-op bulk method.Reviewed by Cursor Bugbot for commit ff5e42b. Bugbot is set up for automated code reviews on this repo. Configure here.