Repository navigation
Fix file restore from backward diffs - #77
Merged
Merged
Conversation
wonder-sk
approved these changes
May 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR address issue with geopackage file reconstruction for some older project version. There is also small test refactoring.
How to reproduce: Try to reconstruct file at version where no change was done going backward.
Issue:
The actual issue was found in file diff change method which evaluates basefile and list of diffs to be applied for successful geopackage reconstruction. When going backward, version of interest does not need to be the one with diff. Previous implementation dropped last diff in list automatically even though it might have been needed. This would result either in no diffs found (hence failed reconstruction) or not all diffs applied (data corruption / loss).
Fix: From history of diffs we only remove diff if it belongs to version of interest (because its application would result in reconstruction of previous version).