Skip to content

Fix projects access update endpoints - #67

Merged
varmar05 merged 5 commits into
developfrom
fix_direct_project_share
Apr 26, 2023
Merged

Fix projects access update endpoints#67
varmar05 merged 5 commits into
developfrom
fix_direct_project_share

Conversation

@varmar05

@varmar05 varmar05 commented Apr 21, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This PR deal with project sharing / access updates:

  • reworks public endpoint to support partial update introducing new error framework
  • fixes private endpoint for sharing

@varmar05 varmar05 changed the title Draft: API: Rework projects access update endpoint Fix projects access update endpoints Apr 26, 2023
tomasMizera
tomasMizera reviewed Apr 26, 2023
View reviewed changes
Comment thread server/mergin/sync/private_api_controller.py Resolved
tomasMizera
tomasMizera approved these changes Apr 26, 2023
View reviewed changes

@tomasMizera tomasMizera left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign the licence :)

@varmar05

varmar05 commented Apr 26, 2023

Copy link
Copy Markdown
Collaborator Author

Sign the licence :)

I keep ignoring this. I signed it on master :-) so merge/rebase would do the job.

@varmar05
varmar05 merged commit 0c981c5 into develop Apr 26, 2023
@MarcelGeo
MarcelGeo deleted the fix_direct_project_share branch June 5, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomasMizera tomasMizera tomasMizera approved these changes
@harminius harminius Awaiting requested review from harminius

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@varmar05 @tomasMizera