Skip to content

Access requests list pagination - #57

Merged
varmar05 merged 12 commits into
developfrom
list_pagination_order_search
Jun 22, 2023
Merged

Access requests list pagination#57
varmar05 merged 12 commits into
developfrom
list_pagination_order_search

Conversation

@harminius

@harminius harminius commented Apr 4, 2023 •
edited by MarcelGeo
Loading

Copy link
Copy Markdown
Contributor

Description

Added pagination for Project access requests endpoints:

  • /project/access-requests:
  • /project/access-requests/{namespace}

FE part

  • implement paginated functions for project access requests in Profile and Dashboard
  • changes in project's store

@harminius
harminius requested a review from varmar05 April 6, 2023 08:38
@varmar05 varmar05 changed the title access requests list pagination Draft: access requests list pagination Apr 11, 2023
@MarcelGeo
MarcelGeo changed the base branch from master to develop June 8, 2023 12:37
MarcelGeo
MarcelGeo reviewed Jun 8, 2023
View reviewed changes
Comment thread server/mergin/sync/private_api.yaml Resolved
MarcelGeo
MarcelGeo reviewed Jun 9, 2023
View reviewed changes
Comment thread server/mergin/sync/private_api_controller.py Resolved
MarcelGeo
MarcelGeo reviewed Jun 9, 2023
View reviewed changes
Comment thread server/mergin/sync/private_api.yaml Resolved
MarcelGeo
MarcelGeo reviewed Jun 12, 2023
View reviewed changes
Comment thread server/mergin/sync/private_api.yaml Resolved
MarcelGeo
MarcelGeo reviewed Jun 12, 2023
View reviewed changes
Comment thread server/mergin/sync/private_api_controller.py Resolved
@harminius
harminius force-pushed the list_pagination_order_search branch from d918655 to 04347e3 Compare June 13, 2023 07:49
@harminius harminius changed the title Draft: access requests list pagination access requests list pagination Jun 13, 2023
@harminius harminius changed the title access requests list pagination Draft: access requests list pagination Jun 13, 2023
@MarcelGeo

This comment was marked as resolved.

Sign in to view
MarcelGeo added 2 commits June 13, 2023 13:35
@MarcelGeo
Cleanup: fetching access from Dashboard
5534c7b
@MarcelGeo
Added:
1762c1f 
- pagination to project access requests (ProjectAccessRequestTableTemplate)
- changes in project store (rename functions)
@MarcelGeo
MarcelGeo marked this pull request as draft June 15, 2023 11:07
@harminius
harminius force-pushed the list_pagination_order_search branch from 1762c1f to d765b0a Compare June 16, 2023 07:48
@MarcelGeo
MarcelGeo marked this pull request as ready for review June 20, 2023 15:07
@MarcelGeo MarcelGeo changed the title Draft: access requests list pagination Access requests list pagination Jun 20, 2023
varmar05
varmar05 reviewed Jun 21, 2023
View reviewed changes
Comment thread server/mergin/sync/private_api.yaml Resolved
Comment thread server/mergin/sync/utils.py Resolved
Comment thread server/mergin/tests/test_private_project_api.py Resolved
Comment thread web-app/packages/lib/src/modules/project/components/ProjectAccessRequestTableTemplate.vue Resolved
Comment thread web-app/packages/lib/src/modules/project/store.ts Resolved
@varmar05

varmar05 commented Jun 21, 2023

Copy link
Copy Markdown
Collaborator

@harminius could you please update description so it is clear what was done it this PR?

@MarcelGeo MarcelGeo mentioned this pull request Jun 21, 2023
Merged
@varmar05
varmar05 merged commit 04398f1 into develop Jun 22, 2023
@varmar05
varmar05 deleted the list_pagination_order_search branch June 22, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MarcelGeo MarcelGeo MarcelGeo left review comments
@varmar05 varmar05 varmar05 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@harminius @MarcelGeo @varmar05