Repository navigation
Conversation
Coverage Report for CI Build 38890119696Coverage increased (+0.04%) to 59.637%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats
馃挍 - Coveralls |
馃摝 Build Artifacts Ready
|
Withalion
reviewed
Oct 15, 2026
Withalion
left a comment
Withalion
left a comment
Collaborator
There was a problem hiding this comment.
Seems alright. My humble opinion is that we should filter out these empty entries from the model as they are essentially NULL values and we support setting the value to NULL now from the drawer.
馃摝 Build Artifacts Ready
|
Withalion
approved these changes
Oct 19, 2026
Withalion
left a comment
Withalion
left a comment
Collaborator
There was a problem hiding this comment.
We decided to keep these empty values in the drop down.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4748
A value map with an empty entry (empty value and description) could show an empty drop-down in the form, because the empty value reaches QML as
undefinedand breaks the list model.What changed
MMFormValueMapEditor.qmlturns anundefinedvalue into an empty string when building the list.Behaviour
All value map entries are shown, including the empty one.