Repository navigation
Conversation
Coverage Report for CI Build 39209144254Coverage increased (+0.2%) to 60.019%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions192 previously-covered lines in 4 files lost coverage.
Coverage Stats
💛 - Coveralls |
📦 Build Artifacts Ready
|
Withalion
reviewed
Oct 15, 2026
Withalion
left a comment
Collaborator
There was a problem hiding this comment.
Will need some work, but looks alright. When you implement my comments request review from @tomasMizera
📦 Build Artifacts Ready
|
xkello
force-pushed
the
bugfix/fix-composite-relation
branch
from
October 19, 2026 06:18
354ccea to
900959b
Compare
📦 Build Artifacts Ready
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2315
The app treated every QGIS relation as an association, so deleting a parent never deleted its children. Children added while creating a new parent were also left behind as orphans when that parent was discarded. Relation strength is now read from the QGIS project, and composition relations are respected.
What changed
InputUtils::deleteLinkedFeatures()deletes all features linked to a feature, including nested ones. Normally it only follows composition relations, but when a new feature is discarded it follows every relation.InputUtils::hasCompositionChildren()tells whether deleting features would also delete linked features.AttributeController::deleteFeature()andMultiEditManager::deleteSelectedFeatures()delete the linked features first and then continue with their original delete flow.AttributeController::hasCompositionChildren()andMultiEditManager::selectedFeaturesHaveCompositionChildren()drive the confirmation text.MMFormDeleteFeatureDialog.qmlgets adeletesLinkedFeaturesproperty that switches to the new description.MMFormPage.qmldeletes everything linked to a new feature when it is discarded or deleted in add mode.Behaviour