Repository navigation
Bring back autotest with v2 sync API - #4729
Merged
Merged
Conversation
tomasMizera
added this pull request to stack #4730
September 29, 2026 20:54
tomasMizera
marked this pull request as ready for review
September 29, 2026 20:57
tomasMizera
force-pushed
the
feature/sync-autotests-again
branch
from
September 29, 2026 21:03
482ea73 to
b6ef25b
Compare
Withalion
approved these changes
Oct 5, 2026
Withalion
left a comment
Withalion
left a comment
Collaborator
There was a problem hiding this comment.
Why did you remove testSelectiveSyncAddConfigToExistingProject?
Collaborator
Author
It was a duplicated test |
Withalion
force-pushed
the
feature/sync-autotests-again
branch
from
October 8, 2026 15:28
b6ef25b to
4250279
Compare
Base automatically changed from
feature/sync-v2-decouple-selective-sync
to
feature/sync-v2
October 8, 2026 15:38
Withalion
force-pushed
the
feature/sync-autotests-again
branch
from
October 8, 2026 15:38
4250279 to
3bfc6cd
Compare
Collaborator
|
Interesting observation: manually rebasing this branch on modified previous branch (necessary as Github wasn't able to do it automatically) showed me as co-author, but merging previous branch and deleting it automatically rebased this branch again and removed me as co-author clearing the git history |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Autotests can now compile, run without crashing and mostly succeed. There are two more failing tests that need attention (one because we now consider "already on the latest version" a success and another of unknown reason).
The problems were of course not only in autotests - the fixes several problems in the code:
I commented out the test for push cancel as the logic is not implemented yet.
The PR can be reviewed and merged. The other two tests might need some more work.