Repository navigation
fix: retain metadata when decrypting array entries - #56
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Decrypting an array entry fails with
TypeError: list indices must be integers or slices, not strwhen its encrypted object contains additional metadata. After removing encryption fields,cleanup_nodefalls through to dictionary indexing on the parent list because the object is still nonempty.Resolve the list parent to its first object before checking whether the encrypted node is empty. This retains additional metadata while preserving cleanup of empty objects.
Validation
python -m unittest discover -q).git diff --checkpasses.PR checklist
This targets the current default branch,
main; the template'smasterreference appears outdated.