test: guard requirement list bulk enrichment - #215
Merged
Conversation
|
Fix cargo fmt --check failure that blocked CI lint on PR #215.
mariusmm
force-pushed
the
fix/issue-202-requirement-list-bulk-regression
branch
from
August 3, 2026 21:48
65571e3 to
57bd558
Compare
Collaborator
|
Fixed CI lint (
|
Frontend SPA coverage (by module)
Generated from Vitest |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #202.
Adds regression coverage for the project requirement listing enrichment path so future changes do not reintroduce per-requirement N+1 lookups for verification methods, custom fields, or parent links.
Problem
Issue #202 calls out that project requirement listings are a central API/UI path and must use bounded bulk queries instead of querying related data once per requirement. The current production implementation already batches these enrichments, but there was no lightweight regression guard documenting and protecting that query shape.
Solution
marreq-core/tests/.build_requirement_list_rowsimplementation and asserts that it:.load(...)calls bounded;RequirementServicecalls.Validation
git clonefailed with an environment authorization error), so I could only validate through repository inspection and the GitHub compare view.mainand only addsmarreq-core/tests/requirement_list_bulk_query_regression.rs.Known risks / limitations