Invalid mapping to exists class if source is object

public class Source
{
    public int X1 { get; set; }
}
public class Dest
{
    public int X1 { get; set; }
}

var source = new Source { X1 = 123 };
var dest = new Dest { X1 = 321 };
var dest1 = source.Adapt(dest);
Console.WriteLine($"{dest.X1} {dest1.X1} {dest.GetHashCode()} {dest1.GetHashCode()}");

result: 123 123 19575591 19575591, dest and dest1 are the same object

void somemap(object source)
{
    var dest = new Dest { X1 = 321 };
    var dest1 = source.Adapt(dest);

    Console.WriteLine($"{dest.X1} {dest1.X1} {dest.GetHashCode()} {dest1.GetHashCode()}");
}

var source = new Source { X1 = 123 };
somemap(source);

result: 321 123 32001227 19575591
dest not changed, dest1 is a new object.

Any ideas? Why if source is object, Adapt create a new instance of dest class?

Possibly related to #485

partial fix issue MapsterMapper#537

@andrerav

@andrerav @heggi

Typeof(TSource) always return Type as Object. Need use dynamic or Cast to Runtime Type before Adapt

What happens is this:
Adapt this for Object -> TDistination -> TDistination

In this case use special overload from (it work) :

var dest1 = source.Adapt(dest, source.GetType(), dest.GetType());

But a new instance is when the TDistination is detection as Record #537

@andrerav

@andrerav @heggi

I get fix it, but this
Null propagation for primitive types broke down. By the end of the week this problem will most likely be resolved. :)

Any ideas? Why if source is object, Adapt create a new instance of dest class?

This Adapt Source from object to type of TDestination == source.Adapt<TDestination>()

ObjectAdapter not created Update function

MapsterMapper#524 Object To TDestination fixed

@heggi

Hello @heggi can you provide additional samples for testing?
My fantasy is over, I can’t think of anything else that can be tested in this case :)

Hello, @andrerav fixing of this Issue ready for review #645 . I managed to finish it a little faster than the end of the week :)

@DocSvartz

Thank you @DocSvartz, I will review it later today! :)

Merge pull request #645 from DocSvartz/ObjectModFix

In order to identify issues that are still active, we are closing issues that we believe are either resolved or are dormant. If your issue is still active then please reopen. Thanks.

Navigation Menu

Repository navigation

Invalid mapping to exists class if source is object #524

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Invalid mapping to exists class if source is object #524

Description

Activity

andrerav commented on Jan 29, 2023

DocSvartz commented on Sep 30, 2023

DocSvartz commented on Oct 18, 2023

DocSvartz commented on Oct 18, 2023

DocSvartz commented on Oct 20, 2023

andrerav commented on Oct 20, 2023

stagep commented on Jan 7, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions