Why not .net build-in code generator? #451

Activity

1. devbased commented on Jun 30, 2022

   

   devbased

   on Jun 30, 2022

   Contributor

   More actions

   I think in the case of the mapper, the user should be able to save the generated models in source control. And dotnet generator has a problem with that. You can specify <EmitCompilerGeneratedFiles>true</EmitCompilerGeneratedFiles> and <CompilerGeneratedFilesOutputPath>Generated</CompilerGeneratedFilesOutputPath> but this will emit output from any generators not just from the Mapster.
   Not sure if this has been resolved.
2. GihanSoft commented on Jul 2, 2022

   

   GihanSoft

   on Jul 2, 2022

   Author

   More actions

   @devbased not actually. Auto-gen files are step-able and visible. The only reason can be customizing Auto-gen code and I thing it's not good thing to do.

   👍React with 👍2Reacted by Kamushek and heggi
3. jvmlet commented on Jan 23, 2023

   

   jvmlet

   on Jan 23, 2023

   Last edited by jvmlet

   More actions

   @devbased , the rule of thumb is to NOT commit generated files to SCM.
   For those who also can't see generated files being committed to git , here is the workaround :

   <Target Name="Mapster" BeforeTargets="BeforeBuild;BeforeRebuild" Condition="'$(EnableMapsterCodeGen)' == 'true' And '$(ONCE)' != 'TRUE'">
           <PropertyGroup>
               <MapsterGeneratedFiles>$(MapsterCodeGenDirectory)\*.g.cs</MapsterGeneratedFiles>
           </PropertyGroup>
           <ItemGroup>
               <Compile Remove="$(MapsterGeneratedFiles)" />
           </ItemGroup>
           <RemoveDir Directories="$(MapsterCodeGenDirectory)"/>
           <Exec Command="dotnet msbuild $(ProjectPath) -p:Configuration=$(Configuration)"
                 EnvironmentVariables="ONCE=TRUE" />
           <Exec Command="dotnet tool update Mapster.Tool --global --version=8.3.0" />
           <Exec WorkingDirectory="$(ProjectDir)"
                 Command="dotnet mapster mapper -o $(MapsterCodeGenDirectory) -a $(TargetDir)$(ProjectName).dll " />
           <ItemGroup>
               <Compile Include="$(MapsterGeneratedFiles)" />
           </ItemGroup>
       </Target>

   This target removes the generated files and spawns another dotnet msbuild command to regenerate mappings during normal build.
   If you adopt this approach, DO NOT reference generated classes from your code base, use only interfaces and have DI to discover classes that implements interface that is annotated with [Mapper] attribute :

   Pseudo-Code:

   allAsseblies.AllTypes.Select(type =>{
   var i = type.Interfaces.FirstOrDefault(i->i.HasAttribute<MapperAttribute>());
   return null==i ? null : new (i,type)
   })
   .WhereNotNull()
   .ForEach(pair=>container.Register(pair.type).As(pair.i)

   Usage :

   <PropertyGroup>
       <EnableMapsterCodeGen>true</EnableMapsterCodeGen>
       <MapsterCodeGenDirectory>GeneratedMappings</MapsterCodeGenDirectory>
     </PropertyGroup>
4. stagep commented on Jan 7, 2025

   

   stagep

   on Jan 7, 2025

   More actions

   In order to identify issues that are still active, we are closing issues that we believe are either resolved or are dormant. If your issue is still active then please reopen. Thanks.
5. stagep

   closed this as a duplicateof Source Generators with IMapper Interface #622 on Feb 3, 2025