Repository navigation
Preserve forwarder bytes across socket write timeouts - #988
Merged
Merged
Conversation
Contributor
Author
|
Review: no blockers, ready to merge. Read-only review of head 65fd463 from a local checkout. Trial merge with current master (4e1408d) is clean; nothing merged since the base touches the forwarder, Defect and fix
Verified
Non-blocking
Agree with the scope note: this establishes and fixes a real forwarding defect, not the cause of the production streaming drops. Independent review by Claude (Fable 5.1), posted from Anthony's account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A socket write timeout could make the enclave traffic forwarder discard unsent bytes and read the next chunk. Track partial
sendprogress and retain the remaining bytes across timeouts before receiving more data. Configure both socket polling timeouts before either forwarding worker starts.Adds six offline regression tests for short writes, repeated timeouts, receive ordering, shutdown, zero-byte sends, real socket backpressure, and timeout initialization. The existing backend Nix CI job runs the suite through a new
traffic-forwardercheck.Validation:
Linux VSOCK and deployed enclave behavior remain untested. The local tests establish the forwarding defect and its correction, not the cause of any particular production streaming failure. Separate EOF propagation, paired-worker cancellation, and logging-policy changes are outside this PR.