Handle cancellation rejections when chat deletion reaches its deadline - #980
Draft
AnthonyRonning wants to merge 1 commit into
Draft
AnthonyRonning wants to merge 1 commit into
AnthonyRonning wants to merge 1 commit into
Conversation
Contributor
|
Maple development preview: https://4c764884.maple-ca8.pages.dev Commit: Uses development API, billing, flags and PCR configuration. Cloudflare Access applies. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When chat-history deletion starts cancellation requests and reaches its deadline before awaiting them, a rejected request can escape as an unhandled promise rejection. Attach
Promise.allSettledbefore checking the remaining time so every already-started cancellation has a rejection handler. Timeout reporting and active-run ownership remain unchanged.Adds a deterministic regression that advances the clock past the deadline inside a rejecting cancellation callback. This small fix was found while validating another feature and is separated for independent review.
Validation on this isolated branch: pre-commit formatting, ESLint and TypeScript checks passed; all 1,004 frontend tests passed (0 failures). No native behavior or packaging changed.