feat(opensecret): support per-project OAuth callback allowlists - #978
Merged
Merged
Conversation
This was referenced Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Projects currently have one OAuth callback per provider. This adds a per-provider callback allowlist and an optional
redirect_urlon initiation, so separate browser origins can finish each flow on the origin that started it. Callers that omit the field continue to use the existing default.[]clears them. Serialize the read/merge/write per project, including first insertion.Stack and rollout
This is the first backend foundation PR, based on
master. A later SDK PR can stack on this branch if this PR remains unmerged. SDK API changes, package publication, frontend adoption, provider registration, callback configuration, and traffic activation remain separate work. No SQL schema migration is needed, and this PR does not change deployed callback settings or default hosts.Deploy compatible backend support before any consumer selects a non-default callback. On downgrade, older backends use the default and older settings writers can discard the new list; consumers depending on additional callbacks must first be taken out of that path. Pending OAuth states remain process-local and do not survive backend replacement.
Validation
Local checks used the pinned Nix environments on macOS:
cargo clippy --locked --all-targets --all-features -- -D warningspassed.cargo test --locked --all-features: 714 passed, 26 ignored in the regular run.nix flake check --no-update-lock-filepassed for the current host; workflow and change-detection tests passed.OAuth provider exchanges, released applications, Nitro artifacts, and deployed environments were not exercised. The one credentialed live-provider test remains unrun. GitHub CI will provide the Linux build and in-tree SDK integration results.