Harden Local Proxy browser origin boundary - #710
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security/product policy
This PR makes the smallest policy change needed for #654:
enable_corsfield, default browser access off.OriginorSec-Fetch-Siteheaders before the proxy can use that credential.What changed
Authorizationand SDK-specific headers preflight correctly.Verification
.app: CORS-on browser requests were 401 without auth and 200 with an explicit test key; CORS-off browser-origin/preflight requests were 403/blocked while originless local saved-credential inference remained 200..app, DMG, and updater archive bundled successfully; the command stopped only at the expected updater-signing step because this VM has no private release key.Fixes #654
Does not include #655.