Skip to content

Add copy paste menu items - #43

Merged
AnthonyRonning merged 1 commit into
masterfrom
tauri-copy-paste
Apr 3, 2025
Merged

AnthonyRonning merged 1 commit into
masterfrom
tauri-copy-paste

Conversation

@AnthonyRonning

@AnthonyRonning AnthonyRonning commented Apr 3, 2025 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features
    • Introduced an "Edit" submenu to the application menu across macOS, Windows, and Linux.
    • Enabled standard editing operations including undo, redo, cut, copy, paste, and select all for a more robust user experience.

@coderabbitai

coderabbitai Bot commented Apr 3, 2025 •

Copy link
Copy Markdown

Walkthrough

The changes update the application menu to include a new "Edit" submenu across all platforms. This submenu adds standard editing options—undo, redo, cut, copy, paste, and select all—to the existing menu setup. For macOS, it utilizes SubmenuBuilder to integrate these options alongside the existing app submenu, while Windows/Linux implement a simpler structure. Log messages reflecting the menu configuration have been revised accordingly.

Changes

File(s) Change Summary
frontend/src-tauri/src/lib.rs Added an "Edit" submenu with standard clipboard operations (undo, redo, cut, copy, paste, select all) for both macOS (using SubmenuBuilder) and Windows/Linux; updated related log messages.

Sequence Diagram(s)

sequenceDiagram
    participant App as Application
    participant Menu as Menu Builder
    participant Logger as Logger

    App->>Menu: Initialize Menu Setup
    alt macOS
        Menu->>Menu: Create App Submenu
        Menu->>Menu: Create Edit Submenu using SubmenuBuilder
    else Windows/Linux
        Menu->>Menu: Create Combined Menu with Edit Options
    end
    Menu->>Logger: Log Menu Configuration Update
Loading

Poem

I'm a clever little bunny on the run,
Hopping through the code under the fun sun.
New Edit menus now magically appear,
With undo, copy, and paste so dear.
A hop of joy in every log displayed,
Celebrating the changes that we've made!
🐰✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 34d3958 and 212b8ce.

📒 Files selected for processing (1)
  • frontend/src-tauri/src/lib.rs (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: build-macos (universal-apple-darwin)
  • GitHub Check: build-linux
  • GitHub Check: Cloudflare Pages
🔇 Additional comments (3)
frontend/src-tauri/src/lib.rs (3)

53-64: Well-implemented edit submenu for macOS!

The edit submenu is properly implemented with standard clipboard operations (undo, redo, cut, copy, paste, select all) following macOS UI conventions. The use of separators between logical groups of operations is excellent for usability.


66-66: Good integration of the edit submenu with the existing menu structure.

The edit submenu is correctly added to the main menu alongside the app submenu, maintaining a clean menu hierarchy as expected in macOS applications.


84-92: Good implementation of edit functionality for Windows/Linux.

The edit operations are properly implemented directly in the main menu with appropriate separators, following the simpler menu structure that's common for Windows/Linux applications. All standard editing operations are included.

✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying maple with  Cloudflare Pages  Cloudflare Pages

Latest commit: 212b8ce
Status: ✅  Deploy successful!
Preview URL: https://e63aad42.maple-ca8.pages.dev
Branch Preview URL: https://tauri-copy-paste.maple-ca8.pages.dev

View logs

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

The changes extend the application menu in /frontend/src-tauri/src/lib.rs by introducing an 'Edit' submenu with full clipboard operations on both macOS and Windows/Linux.

  • Added an 'Edit' submenu with undo, redo, cut, copy, paste, and select all options.
  • Enhanced logging to trace menu events and update check operations.
  • Maintained platform-specific menu structures to ensure native user experience.
  • Recommend testing on macOS and Windows/Linux for consistent clipboard behavior.

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@AnthonyRonning
AnthonyRonning merged commit b2819cd into master Apr 3, 2025
@AnthonyRonning
AnthonyRonning deleted the tauri-copy-paste branch April 3, 2025 20:29
benthecarman pushed a commit to benthecarman/Maple that referenced this pull request Aug 26, 2026
…le-proxy-audit-issue-permission-maple-proxy

Allow scheduled security audits to open issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant