refactor!: to biolerplate v2 (MAPCO 6292) - #53
Merged
Merged
Conversation
NivGreenstein
requested changes
Jul 12, 2026
Comment on lines
67
to
69
| POSTGRES_PASSWORD: postgres | ||
| POSTGRES_USER: postgres | ||
| POSTGRES_DB: postgres |
Contributor
There was a problem hiding this comment.
Note:
You can add top-level ENVs and reference them.
See example here
Contributor
There was a problem hiding this comment.
remove the env
you added a top-level env
| ...connectionOptions, | ||
| password: undefined, | ||
| ssl: { | ||
| key: readFileSync(ssl.key), |
Contributor
There was a problem hiding this comment.
If readFilesSync fails, it throws an error. make sure it throws an indicative one
| const dbConfig = config.get<DbConfig>('db'); | ||
| const connectionOptions = createConnectionOptions({ entities: ENTITIES_DIRS, ...dbConfig }); | ||
| const config = container.resolve<ConfigType>(SERVICES.CONFIG); | ||
| const dbConfig: DbConfig = config.get('db'); |
Contributor
There was a problem hiding this comment.
No need to assign DbConfig type. The type will auto resolve
| import { readPackageJsonSync } from '@map-colonies/read-pkg'; | ||
|
|
||
| export const SERVICE_NAME = readPackageJsonSync().name ?? 'unknown_service'; | ||
| export const DEFAULT_SERVER_PORT = 80; |
Contributor
There was a problem hiding this comment.
please default to port 8080
Comment on lines
+107
to
+109
| useFactory: (container): HealthCheck => { | ||
| const connection = container.resolve<Connection>(Connection); | ||
| return getDbHealthCheckFunction(connection); |
Contributor
There was a problem hiding this comment.
create a function somewhere else. Don't create logic at containerConfig
Comment on lines
+23
to
+24
| console.error('😢 - failed initializing the server'); | ||
| console.error(error); |
Contributor
There was a problem hiding this comment.
why not using logger if its available? revert relevant changes
Comment on lines
+5
to
+6
| // The typeorm CLI cannot await the async application config, so the db section is read directly | ||
| // from the local config file, honoring the same DB_* env overrides the schema defines for the application. |
Contributor
|
Also, missing some files |
NivGreenstein
requested changes
Jul 19, 2026
| DB_NAME: postgres | ||
| DB_USERNAME: postgres | ||
| DB_PASSWORD: postgres | ||
| # DB_SCHEMA: public |
Comment on lines
67
to
69
| POSTGRES_PASSWORD: postgres | ||
| POSTGRES_USER: postgres | ||
| POSTGRES_DB: postgres |
Contributor
There was a problem hiding this comment.
remove the env
you added a top-level env
|
|
||
| export const SERVICE_NAME = readPackageJsonSync().name ?? 'unknown_service'; | ||
| export const DEFAULT_SERVER_PORT = 80; | ||
| export const DB_HEALTHCHECK_TIMEOUT_MS = 5000; |
Contributor
There was a problem hiding this comment.
remove it if you added it to the config
NivGreenstein
previously approved these changes
Jul 23, 2026
Powfu2
changed the title
Powfu2
changed the title
NivGreenstein
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues: MAPCO-6292
Closes #XXX ...
Further information: