Repository navigation
chore(deps): fix npm audit advisories - #31
Conversation
There was a problem hiding this comment.
Adversarial review
The change raises the runtime minimatch dependency from ^10.2.5 to ^11.0.5, refreshes several dev dependencies that come in through other packages (glob 14, path-scurry 3, rimraf, lru-cache, fast-uri, zod), and replaces the .nsprc audit exceptions with one new, dated exception for the older minimatch that skott and depcheck still pull in. Neither reviewer found any issues. The code already uses the named minimatch import, so v11 dropping its default export doesn't affect it. Minimatch 11's Node 20 || >=22 requirement also fits within the package's >=24 engines field. The one point to keep in mind is that the braces and sprintf-js exceptions were removed while those package versions are still in the lockfile; one reviewer concluded that those advisories no longer fire.
No new findings were raised.
Adversarial review by yoke: reviewed with claude-opus-5-5-global and gpt-6.1-sol; combined with claude-opus-5-5-global.
To re-run this review, mark the PR as draft and then ready for review again.
What
Clears the
zod(high),fast-uri,globandminimatchadvisories.minimatchmoves to 11. Theminimatchadvisory left in skott's dependency tree gets a dated.nsprcexception, and the stalebracesandsprintf-jsexceptions are removed.Why
npm auditreported 9 vulnerabilities on main, including a high inzod.How
Overriding skott's
minimatchto 11 breaksdepcheck, which calls the default export 11 removed. skott and depcheck are already latest, so it follows the existing exception pattern.