Skip to content

chore(deps): fix npm audit advisories - #31

Merged
staff0rd merged 1 commit into
mainfrom
staff0rd/fix-npm-audit
Nov 11, 2026
Merged

staff0rd merged 1 commit into
mainfrom
staff0rd/fix-npm-audit

Conversation

@staff0rd

Copy link
Copy Markdown
Member

What

Clears the zod (high), fast-uri, glob and minimatch advisories. minimatch moves to 11. The minimatch advisory left in skott's dependency tree gets a dated .nsprc exception, and the stale braces and sprintf-js exceptions are removed.

Why

npm audit reported 9 vulnerabilities on main, including a high in zod.

How

Overriding skott's minimatch to 11 breaks depcheck, which calls the default export 11 removed. skott and depcheck are already latest, so it follows the existing exception pattern.

@staff0rd
staff0rd enabled auto-merge (squash) November 11, 2026 02:01

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adversarial review

The change raises the runtime minimatch dependency from ^10.2.5 to ^11.0.5, refreshes several dev dependencies that come in through other packages (glob 14, path-scurry 3, rimraf, lru-cache, fast-uri, zod), and replaces the .nsprc audit exceptions with one new, dated exception for the older minimatch that skott and depcheck still pull in. Neither reviewer found any issues. The code already uses the named minimatch import, so v11 dropping its default export doesn't affect it. Minimatch 11's Node 20 || >=22 requirement also fits within the package's >=24 engines field. The one point to keep in mind is that the braces and sprintf-js exceptions were removed while those package versions are still in the lockfile; one reviewer concluded that those advisories no longer fire.

No new findings were raised.


Adversarial review by yoke: reviewed with claude-opus-5-5-global and gpt-6.1-sol; combined with claude-opus-5-5-global.

To re-run this review, mark the PR as draft and then ready for review again.

@staff0rd
staff0rd merged commit a680bf9 into main Nov 11, 2026
4 checks passed
@staff0rd
staff0rd deleted the staff0rd/fix-npm-audit branch November 11, 2026 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants