fix: board drag-and-drop writes to [object Object] instead of property name - #559
Open
Ju4n5e wants to merge 1 commit into
Open
fix: board drag-and-drop writes to [object Object] instead of property name#559Ju4n5e wants to merge 1 commit into
Ju4n5e wants to merge 1 commit into
Conversation
…oard drag-and-drop
When dragging a card between columns on a board view, the _groupField
prop is a column descriptor object (e.g. {name: "Status", type: "option", ...}).
Using it directly as a computed property key calls .toString(), producing
the literal string "[object Object]" instead of the property name.
This causes the frontmatter to gain a corrupted key "[object Object]"
while the intended property (e.g. Status) is never updated, making
drag-and-drop appear broken.
The fix extracts .name from the field object at both usage sites in
dropListItem — consistent with how the plugin's own template expressions
already handle it (e.g. `$root.props['_groupField']?.name`).
Fixes Make-md#558
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"[object Object]"frontmatter key instead of the actual grouped property name (e.g.,Status)_groupFieldis a column descriptor object, not a string — using it as a computed property key calls.toString(), producing"[object Object]".namefrom the field object at both usage sites indropListItem, consistent with how the plugin's own template expressions already handle it ($root.props['_groupField']?.name)Fixes #558
Test plan
Statusproperty and set up a board view grouped byStatusStatusproperty updates correctly and no"[object Object]"key appearsupdateTableValuecode path)🤖 Generated with Claude Code