udp sendto not working #319

Activity

1. stalkerg commented on Mar 2, 2020

   

   stalkerg

   on Mar 2, 2020

   Author

   More actions

   with uvloop 0.13.0 I have next error:

     File "uvloop/loop.pyx", line 2980, in create_datagram_endpoint
     File "uvloop/handles/udp.pyx", line 86, in uvloop.loop.UDPTransport._connect
   OSError: [Errno 106] Transport endpoint is already connected
   

   in same time with classic eventloop I have no any problems.
2. stalkerg commented on Mar 2, 2020

   

   stalkerg

   on Mar 2, 2020

   Author

   More actions

   ok, with version 0.12.2 everything working fine.
3. stalkerg commented on Mar 2, 2020

   

   stalkerg

   on Mar 2, 2020

   Author

   More actions

   after bisect I found this commit c2b65bc it's break UDP for aiosip (and I think not only).
4. 1st1 commented on Mar 4, 2020

   

   1st1

   on Mar 4, 2020

   Member

   More actions

   Thanks for reporting this. Could you please write a functional test that would exhibit the bug?
5. stalkerg commented on Mar 5, 2020

   

   stalkerg

   on Mar 5, 2020

   Last edited by stalkerg

   Author

   More actions

   @1st1 yes, please

   import asyncio
   import uvloop
   
   uvloop.install()
   
   
   class UDP(asyncio.DatagramProtocol):
       def __init__(self):
           pass
   
       def connection_lost(self, error):
           print("connection_lost", error)
   
   
   async def main():
       loop = asyncio.get_event_loop()
       transport, proto = await loop.create_datagram_endpoint(
           lambda: UDP(),
           local_addr=("192.168.1.9", 6001),
           remote_addr=("192.168.1.3", 5060)
       )
       print("Before sending the message without a destination")
       transport.sendto(b"deadbeef")
       await asyncio.sleep(1)
       print("After sending the message without a destination")
       
       print("Before sending the message with a destination")
       transport.sendto(b"deadbeef", ("192.168.1.3", 5060)) # will be connection lost
       await asyncio.sleep(1)
       print("After sending the message with a destination")
   
   
   asyncio.get_event_loop().run_until_complete(main())

   looks like it happens if you trying to send a message with destination address and you have already specified it in create_datagram_endpoint as remote_addr. Without uvloop all working perfectly.
6. jlaine commented on Mar 5, 2020

   

   jlaine

   on Mar 5, 2020

   Last edited by jlaine

   Contributor

   More actions

   You cannot both "connect" the endpoint to a remote address and use sendto() with a destination address.

   This is the case in vanilla asyncio too:

   https://github.com/python/cpython/blob/85cf1d514b84dc9a4bcb40e20a12e1d82ff19f20/Lib/asyncio/selector_events.py#L1028

   I wonder if uvloop is raising ValueError as it should?

   EDIT My bad if the same remote address is used for create_datagram_endpoint and sendto it works with vanilla asyncio, so it should work with uvloop too.
7. 1st1

   added

   bug

   on Mar 11, 2020
8. fantix

   added 2 commits that reference this issue on Apr 10, 2020

   Allow sendto the same addr if remote_addr is set

   ...

   This issue will close once commit 7a73c97 is merged into the 'master' branch.

   7a73c97

   Allow sendto the same addr if remote_addr is set

   ...

   This issue will close once commit c952030 is merged into the 'master' branch.

   c952030
9. fantix

   closed this as completedin #332on Apr 11, 2020
10. fantix

    added a commit that references this issue on Apr 11, 2020

    Allow sendto the same addr if remote_addr is set

    ...

    This issue will close once commit 1d9267a is merged into the 'master' branch.

    1d9267a