Tabbed online accounts with character and party columns - #952
Open
eduardosmaniotto wants to merge 1 commit into
Open
Tabbed online accounts with character and party columns#952eduardosmaniotto wants to merge 1 commit into
eduardosmaniotto wants to merge 1 commit into
Conversation
…lumns Split the logged-in page into Players / Off-level Players / Bot Players tabs, gated on the offlevel and bot plugin states. Add selected-character and party columns with party-grouped ordering shared across all three tables, and cover the ordering and distributed fallbacks with tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworks the
/logged-in(Online accounts) page:/offlevelcommand plugin is active), Bot Players (only when the bot feature plugin is active).—in distributed deployments.BotManager, soDisconnectAccountAsynccannot stop them cleanly — that would leave stale entries behind).How
LoggedInAccount/OfflineAccountextended withCharacterName,PartyMaster,PartySize; newBotAccount+BotAccountServicefollowing the existingIDataService<T>pattern.OnlineAccountOrdering.OrderPartyGrouped<T>()overIPartyGroupedAccountinstead of triplicated sort logic.PartyBadge.razorcomponent instead of string-built HTML.PlayerInforecord instead of tuple, dead bot filter inOfflineAccountServicereplaced with an explanatory comment.