fix(web): changed-files filter in the diff view now filters and fuzzy-matches - #108
Merged
Merged
Conversation
- Rank substring matches ahead of fuzzy path matches - Add coverage for fuzzy matching and unmatched queries
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Filter changed files" input in the diff view's file picker never removed anything from the list. The filtered entries were only passed to the combobox's
filteredItemsprop, which Base UI uses solely to decide when to show the empty state; the explicit child items always rendered. The filter itself was also a plain substring match.The list now renders the filtered entries, and
filterDiffFilesranks results with the sharedsearchRankinghelper: substring hits on the path come first, ordered by where they appear, followed by subsequence (fuzzy) matches such asdfpnlforDiffPanel.tsx. Tests cover fuzzy matching, ranking, and the no-match case.Verified with
vp test run apps/web/src/lib/diffFileNavigation.test.ts, lint, and a web typecheck.Work done by Claude Fable 5.1 via Claude Code in T3 Code.