feat(web): flag reviewed files for follow-up and block staging until cleared - #106
Merged
Merged
Conversation
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
While reviewing in the diff panel, a file that still needs more work or a comment had no state of its own. Collapsing it was the only signal, and a misclick on a collapsed header could stage it anyway. Git cannot hold "not done yet", so the flag needs a home of its own.
Fix
A per-file follow-up flag stored on the thread as orchestration events, so it syncs to every client, survives reloads, and is deleted with the thread.
thread.review-file.flag/thread.review-file.unflagcommands and matching events. The decider resolves unflag to the paths actually flagged, and unflag without paths clears them all. Re-flagging and no-op unflags re-emit without touchingupdatedAt.reviewFollowUpPathson the thread read model, projected in memory and into a newreview_follow_up_paths_jsoncolumn (migration 053). Thread shells are unchanged.threadReviewFlagsso clients can detect support.Mobile decodes the new field but shows no badge or control yet.
Tests
Follow-up to #100.
Built with Claude Fable 5.1 via Claude Code in T3 Code.