Skip to content

Fix: Add enchant stats to character #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AngeloTadeucci merged 4 commits into from
May 26, 2025
Merged

Fix: Add enchant stats to character #453

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
31cfbc4
增强角色属性计算逻辑
AngeloTadeucci May 22, 2025
a0726f4
Merge branch 'master' into pr/453
AngeloTadeucci May 26, 2025
fe7f94f
Simplify & translate
AngeloTadeucci May 26, 2025
0caf261
Update StatsManager.cs
AngeloTadeucci May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions Maple2.Server.Game/Manager/StatsManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,20 @@ private void AddEquips(FieldPlayer player) {
if (item.Stats != null) {
AddItemStats(item.Stats);
}

// Add enhancement attributes to character attributes
if (item.Enchant is not null) {
foreach (KeyValuePair<BasicAttribute, BasicOption> kvp in item.Enchant.BasicOptions) {
Values[kvp.Key].AddTotal(kvp.Value);
}
}

if (item.LimitBreak is not null) {
foreach (KeyValuePair<BasicAttribute, BasicOption> kvp in item.LimitBreak.BasicOptions) {
Values[kvp.Key].AddTotal(kvp.Value);
}
}

Log.Logger.Debug("Calculating Gearscore. Item ID: {id} - Gearscore: {gearscore} - Rarity: {rarity}, Enchant Level: {enchantLevel}, Limit Break Level: {limitBreakLevel}", item.Metadata.Id, item.Metadata.Property.GearScore, item.Rarity, item.Enchant?.Enchants ?? 0, item.LimitBreak?.Level ?? 0);
Values.GearScore += Lua.CalcItemLevel(item.Metadata.Property.GearScore, item.Rarity, item.Type.Type, item.Enchant?.Enchants ?? 0, item.LimitBreak?.Level ?? 0).Item1;
player.Session.Dungeon.UpdateDungeonEnterLimit();
Expand Down Expand Up @@ -206,9 +220,6 @@ private void StatConversion(FieldPlayer player) {
private void AddItemStats(ItemStats stats) {
for (int type = 0; type < ItemStats.TYPE_COUNT; type++) {
foreach ((BasicAttribute attribute, BasicOption option) in stats[(ItemStats.Type) type].Basic) {
if (attribute is BasicAttribute.CriticalDamage) {
Log.Logger.Information("Adding {attribute} {option} to {actor}", attribute, option, Actor);
}
Values[attribute].AddTotal(option);
}
foreach ((SpecialAttribute attribute, SpecialOption option) in stats[(ItemStats.Type) type].Special) {
Expand Down