Read itemgemstoneupgrade EquipPart as a comma list - #83
Merged
Merged
Conversation
The client parses EquipPart as a comma-separated list into a bitmask (CItemGemStoneUpgradeTable_Load), the same as itemlapenshardupgrade, whose EquipPart is already [M2dArray] int[]. Match that type here. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ItemGemstoneUpgrade.EquipPartwas a singleint, but the client reads it as a comma list:CItemGemStoneUpgradeTable_Load(GMS214036ed20) splits the attribute and ORs1 << (v-1)for each value into a mask.itemlapenshardupgrade.xmlshares the same attribute and loader shape and is already[M2dArray] int[], so this brings the two in line. Maple2 needs the list to check socket targets the way the client does (MS2Community/PrivateMaple2#1312).Xml/Table/ItemGemstoneUpgrade.cs:EquipPartfrom[XmlAttribute] intto[M2dArray] int[](default,delimiter). Current data only uses single values (3 and 4), which now come back as one-element arrays. Breaking for any consumer that readsEquipPartas an int.PackageVersion2.4.24 → 2.4.25.Verification
dotnet buildclean.TestParseItemGemstoneUpgradeandTestParseItemLapenshardUpgradepass. Maple2 was built and its tests run against a locally packed2.4.25-debug.1.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.