Conversation
channemann
added a commit
that referenced
this pull request
Sep 11, 2017
kenstack
pushed a commit
to kenstack/Loop
that referenced
this pull request
Feb 22, 2018
Ns profile update
erikdi
pushed a commit
to erikdi/Loop
that referenced
this pull request
Feb 10, 2019
jeremybarnum
pushed a commit
to jeremybarnum/Loop
that referenced
this pull request
Jul 15, 2026
LoopKit#7 core) done in the overnight batch; flag the deferred 3-way degraded-mode picker and the TEMP-TEST-CAP value decision
jeremybarnum
pushed a commit
to jeremybarnum/Loop
that referenced
this pull request
Jul 17, 2026
PodController.resume(schedule: nil) fell back to the bench-proof flat
0.5 U/hr schedule, and the coordinator passed nil whenever settings had
not synced (real state after watch reinstalls). Resume RE-PROGRAMS the
pod's STORED basal table - a state that outlives the loan: the phone
believes the pod still holds the wearer's true schedule and never
re-sends it, so every later temp-expiry auto-revert reverts to the
fabricated flat rate (0.2 U/hr overnight wearer -> 2.5x scheduled,
indefinitely, invisibly). Review C9.
Three changes:
1. Resuming Sport Mode's own suspend (the bounded rate-0 temp, the only
suspend it creates) is now a plain cancelTempBasal - the pod reverts
to its own STORED true schedule. No reprogramming, no schedule needed,
correct even with zero settings sync.
2. The true-suspend path (pre-loan edge; PodControlStatus gains a real
`suspended` field from deliveryStatus) requires the synced schedule as
a non-optional parameter - the proof-schedule fallback is deleted from
the dosing path. Without a synced schedule it refuses loudly ("resume
from the iPhone") instead of inventing rates. State keeps the C4
transactional pattern (a refused resume still shows Suspended - the
truth).
3. When it does program, the schedule's own grant-captured timezone is
used, not the watch's current zone (partial DST/travel gap closure).
setupStep2's proof schedule is untouched: that is the bench pod-ACTIVATION
rig (watch-primed pods, not loan takeovers) and stays on the pre-production
strip list.
Approved by Jeremy (fix batch LoopKit#8). watchOS build verified.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.