Repository navigation
feat: choose the number of elements from the data (phase 6.4) - #141
Open
lachlangrose wants to merge 5 commits into
Open
lachlangrose wants to merge 5 commits into
lachlangrose wants to merge 5 commits into
Conversation
Add suggest_nelements and summarise_data, an Automatic setting, and one model manager method for the interpolator arguments that reads the saved settings instead of the class defaults. The feature panel shows the number and keeps a number that the user sets.
- Calculate the element count from the model extent as well as from the number of data rows: the volume of the model divided by the cube of the median spacing of the data points. Use the larger number. - When the user selects Automatic again, show the number of the settings, not the last number of the user. - The check box follows the global Automatic setting. Without it, the box uses the fixed number of the settings. - Correct the sign of the normal in _normals_from_strike_dip. - Add tests for interpolator_arguments and for the save and load of the overrides.
lachlangrose
added a commit
that referenced
this pull request
Oct 30, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
interpolation_size.pywithsuggest_nelementsandsummarise_data: they calculate a number of interpolation elements from the data.docs/usage/interface.mdare updated.Stacked on #140.
Test plan
tests/unit/test_interpolation_size.py🤖 Generated with Claude Code