Repository navigation
feat: phase 1 shared layer roles and derived-data records - #132
Open
lachlangrose wants to merge 3 commits into
Open
lachlangrose wants to merge 3 commits into
lachlangrose wants to merge 3 commits into
Conversation
1 of 7 tasks
Add shared layer roles (geology, unit field, fault traces, structure, basal contacts, DEM) and a contacts source setting. The map2loop tools show the roles as their default layers. Record a hash of the inputs of the basal contacts, the calculated thickness and the strat_order field. Show the out-of-date results in the stratigraphic column tab with an Update button. Record if a unit thickness was typed or calculated, and do not replace a typed thickness.
- The Basal Contacts and Thickness tools record the inputs that the status check reads (the layer roles and the saved tool settings). A layer that the user selects for one run no longer makes the result out of date. An empty field is the same as no field. - thickness_inputs contains only the settings that the calculator type uses. The calculated contacts do not depend on the faults or the unit lists of the Basal Contacts tool. - The thickness is not an input of the styled fields. - Update on the styled fields makes the graduated classes again when the layer is styled by strat_order, with the recorded colour ramp. - With "duplicate layer", the paint tool records the <name>_strat copy. - The Thickness tool records a run for all result types.
lachlangrose
force-pushed
the
feat/shared-layer-roles
branch
from
October 30, 2026 07:41
2258721 to
abb6e57
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 1 of the usability plan. This PR is stacked on #131 (base:
fix/phase-0-quick-fixes).main/layer_roles.py):geology,geology_unit_field,fault_traces,structure,basal_contacts,dem, and a contacts source setting ("Calculate from geology polygons" or "Use a contacts layer"). They send a change event and are saved with the application state. Old state files load with default values.basal_contactsrole and as the model contacts (only with the "Calculate from geology polygons" source).main/derived_data.py): a hash of the inputs of the basal contacts, calculated thickness andstrat_orderfield. A reorder marks them out of date. A colour change does not. A reorder and its undo leave them current.docs/usage/interface.md.Notes
Test plan
pytest testsin QGIS 3.42 (232 passed): unit tests for role storage, save/load, change event, input hash and thickness source🤖 Generated with Claude Code