Repository navigation
Derive basal contacts from geology map in thickness calculators - #121
Open
lachlangrose wants to merge 4 commits into
Open
lachlangrose wants to merge 4 commits into
lachlangrose wants to merge 4 commits into
Conversation
The Processing thickness calculator now extracts basal contacts from the geology layer and the stratigraphic column when no basal contacts layer is given. The basal contacts input is optional.
Before, an error in map2loop gave an empty result and the user did not see the cause. Now extract_basal_contacts raises a RuntimeError with the cause. The GUI and the Processing algorithms show this message.
The algorithm now uses the geology feature source for the units, the bounding box and the basal contact extraction. Thus "selected features only" applies to all of them, and an input that is not a map layer works. Add an optional faults input. The faults are used when the algorithm extracts the basal contacts from the geology. Show an error if the extraction finds no basal contacts. Add tests for basal contacts from the geology layer and from the selected features only.
lachlangrose
force-pushed
the
feat/thickness-calculator-auto-basal-contacts
branch
from
October 31, 2026 00:45
48f6296 to
5cd2a60
Compare
- extract_basal_contacts had a mutable default (ignore_units=[]) and added None to it, so the list grew at each call. It also changed the list of the caller. Use None and a new list. - The thickness algorithm read MAX_LINE_LENGTH with parameterAsSource, so StructuralPoint always got None. Use parameterAsDouble.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extract_basal_contacts/ map2loopContactExtractorlogic (no duplication).Test plan