Repository navigation
feat: allow loop-interpolation 0.2 and add the native extra - #381
Merged
Merged
Conversation
LoopStructural required loop-common<0.1.0 and loop-interpolation<0.1.0, but this repository releases loop-common 0.1.0 and loop-interpolation 0.2.0. Only loop-interpolation 0.2.0 has solver='native' (the Rust core), so pip could not install the native solver next to LoopStructural. - Require loop-common>=0.1.0,<0.2.0 and loop-interpolation>=0.2.0,<0.3.0. - Add the extra loopstructural[native] (loop-interpolation[native]).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
LoopStructural requires
loop-common<0.1.0andloop-interpolation<0.1.0. This repository already releasesloop-common0.1.0 andloop-interpolation0.2.0, and onlyloop-interpolation0.2.0 hassolver='native'(the Rust core,loop-interpolation-core). So pip cannot install the native solver next to LoopStructural. The QGIS plugin needs it.Changes
loop-common>=0.1.0,<0.2.0andloop-interpolation>=0.2.0,<0.3.0.loopstructural[native], which installsloop-interpolation[native].uv.lock.The commit is a
feat:, so release-please makes 1.11.0.Checks
In a clean environment with the packages from PyPI (
pip install .[native], Windows, Python 3.14):cg10.6 s,native2.5 s. The largest difference is 0.1 % of the value range.tests/unit: 700 passed, 7 failed. The 7 failures are intests/unit/interpolator/test_2d_p1_p2_support.py, and they come from NumPy 2.5:np.crossno longer accepts 2D vectors. With NumPy 2.4.6 all 14 tests of that file pass. That is a separate problem from this PR.🤖 Generated with Claude Code