Repository navigation
feat: trilinear interpolation on PropertyGrid - #369
Merged
lachlangrose merged 1 commit intoNov 1, 2026
Merged
lachlangrose merged 1 commit into
lachlangrose merged 1 commit into
Conversation
lachlangrose
force-pushed
the
feature/property-grid-trilinear
branch
from
November 1, 2026 05:51
7e8cfc7 to
54d2df3
Compare
lachlangrose
changed the base branch from
master
to
refactor/property-grid-geometry
November 1, 2026 05:51
lachlangrose
force-pushed
the
feature/property-grid-trilinear
branch
from
November 1, 2026 06:08
54d2df3 to
1f1ed73
Compare
lachlangrose
marked this pull request as ready for review
November 1, 2026 06:13
…ometry Move the pure-geometry pieces of the interpolation support into StructuredGrid3DGeometry so the support and PropertyGrid share them: trilinear weights, position_to_local_coordinates, position_to_dof_coefs, position_to_cell_corners / _vertices, node_indexes_to_position, element_size / element_scale and evaluate_value (now also accepting (n_nodes, k) data). PropertyGrid.evaluate_value(name, points) interpolates a node property at arbitrary points (NaN outside), which is what is needed to transfer a property onto another support. The structured-support reference test is unchanged and passes. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
lachlangrose
force-pushed
the
feature/property-grid-trilinear
branch
from
November 1, 2026 06:54
1f1ed73 to
47158eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trilinear interpolation of node values on
PropertyGrid, so a property can be transferred onto another support:grid.evaluate_value("f", other_support.nodes).Change
The pure-geometry pieces of the interpolation support move into
StructuredGrid3DGeometry, so the support andPropertyGridshare them (moved verbatim):trilinear,position_to_local_coordinates,position_to_dof_coefs,position_to_cell_corners/_vertices,node_indexes_to_position,element_size/element_scale,evaluate_value.evaluate_valuenow also accepts(n_nodes, k)data (the 1-D path is unchanged).PropertyGrid.evaluate_value(name, points)interpolates the node propertyname; NaN outside the grid. Points are in the grid's own frame (no rotation).Tests
test_property_grid.py: a linear field is reproduced exactly at random points; node values are returned at the nodes; midpoint equals the mean of the corner values; NaN outside; multi-component data; agreement with the support's ownevaluate_value; transfer onto a 3x finer support. Swapping two trilinear corner weights fails 12 of the 51 tests in that file.packages/loop_common/tests: 234 passed;packages/loop_interpolation/tests: 606 passed;tests: 737 passed. ruff clean on changed files.Not included: gradients on
PropertyGrid; interpolation of cell properties (they are piecewise constant: usecell_value_at).🤖 Generated with Claude Code