[th317erd]

Summary

Fixes #11.

This prevents the SQLite log sink from persisting raw notify backend TRACE/DEBUG messages such as:

• inotify event: ...
• adding inotify watch: ...
• removing inotify watch: ...
• FSEvent: ...
• kqueue event: ...
• Windows backend Event: path = ...

These messages are emitted through the log compatibility target by notify itself. In Codext, AuthWatch watches the top-level CODEX_HOME directory, and the SQLite log DB normally lives in CODEX_HOME. That can create a self-amplifying loop:

1. Codext writes a log row.
2. SQLite updates logs_2.sqlite-wal.
3. The CODEX_HOME watcher sees the WAL change.
4. notify emits a raw TRACE log for the file event.
5. The SQLite log sink persists that TRACE row.
6. SQLite updates the WAL again.

The fix keeps normal application logs intact, including unrelated target="log" TRACE rows, but drops low-level file-watch backend noise before it reaches the SQLite log DB.

Notes

The existing opentelemetry_sdk TRACE/DEBUG filter is preserved. This patch moves filtering after message extraction so the sink can identify specific notify backend messages.

Testing

cargo test -p codex-state sqlite_sink_drops_low_level_notify_logs --lib
cargo test -p codex-state sqlite_sink_drops_low_level_opentelemetry_sdk_logs --lib
cargo test -p codex-state --lib
cargo build -p codex-cli

I also ran a manual default-path retest with the patched binary:

• Removed the temporary sqlite_home workaround so SQLite returned to ~/.codex-work.
• Confirmed the patched process had ~/.codex-work/logs_2.sqlite-wal open.
• Created, modified, and removed 80 disposable top-level files in ~/.codex-work.
• Confirmed WAL size and bad-row counts did not increase.

[andrei-hasna]

Merge is blocked for PR #12 as currently shaped.

Evidence:

• GitHub reports the PR as conflicting/dirty against current main (base 0a8f60d, head 1c076d5), with no checks or reviews reported.
• A dry-run merge against current main conflicts in unrelated release/TUI/Cargo/docs/workflow files, so this is not safe to merge as a log-sink-only change.
• Current main already has the broader SQLite log-sink fix from e98d43a: codex-rs/state/src/log_db.rs defines log_db::default_filter(), disables target "log", and app-server/TUI install that filter. That covers notify backend logs in production paths.
• The focused current-main validation passed: CARGO_HOME=/tmp/codext-pr12-cargo-home CARGO_TARGET_DIR=/tmp/codext-pr12-target cargo test -p codex-state sqlite_sink.

Recommendation: do not merge or cherry-pick this PR as-is. If maintainers want the narrower message-pattern behavior instead of current broad target=log suppression, it should be reimplemented fresh from current main with tests that exercise log_db::default_filter().

[andrei-hasna]

Updated worker review: PR #12 still should not be merged as-is.

Evidence from current origin/main (0a8f60d67) and PR head (1c076d5a):

• GitHub reports mergeable=CONFLICTING / mergeStateStatus=DIRTY; there are no reported checks or reviews.
• A read-only merge-tree dry run conflicts in unrelated reapply/release/TUI/Cargo/docs files, including .agents/skills/codex-upstream-reapply/SKILL.md, .github/workflows/rust-release.yml, AGENTS.md, README.md, codex-rs/Cargo.lock, codex-rs/Cargo.toml, and multiple codex-rs/tui/* files.
• The focused log_db.rs patch does not apply cleanly to current main, and codex-rs/state/src/log_db_filter_tests.rs no longer exists on current main, so this needs a fresh current-base implementation if still desired.
• Current task guardrails for this reapply worktree prohibit adding/modifying tests, while the PR adds codex-rs/state/src/log_db_filter_tests.rs.
• Adversarial review found code risks in the focused patch: it records every event into MessageVisitor before dropping OpenTelemetry TRACE/DEBUG events, adding overhead to high-volume logs, and its target="log" prefix matching is not specific to notify because bridged records can use the generic tracing target.

Validation run on current main, no repo changes made:
CARGO_HOME=/tmp/codext-pr12-cargo-home CARGO_TARGET_DIR=/tmp/codext-pr12-target cargo test -p codex-state log_db::tests -- --nocapture -> 6 passed.

Recommendation: do not merge or cherry-pick PR #12. If notify-specific SQLite log filtering is still wanted, reimplement it fresh against current main with a filter that avoids extra work for already-dropped high-volume targets and is specific to notify-originated bridge records.

[andrei-hasna]

Verifier correction for the previous blocker note: current origin/main (0a8f60d67) does contain codex-rs/state/src/log_db_filter_tests.rs; PR #12 modifies that file rather than adding a brand-new file against current main. The merge decision is unchanged: GitHub still reports mergeable=CONFLICTING / mergeStateStatus=DIRTY, gh pr checks reports no checks on fix-sqlite-notify-log-loop, and a dry-run git merge-tree origin/main origin/pr/12 still conflicts across unrelated reapply/release/TUI/Cargo/docs files. Under the current reapply guardrails, the PR's test changes also remain outside the allowed change shape for this task. Recommendation remains: do not merge or cherry-pick PR #12 as-is; reimplement any desired notify-specific SQLite log filtering fresh on current main.