Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
github-actions
Bot
added
vouch:unvouched
Author
|
Hey @LoganRupe let me know if you need any more info from me or any changes :) |
LoganRupe
reviewed
Sep 16, 2026
LoganRupe
left a comment
LoganRupe
left a comment
Owner
There was a problem hiding this comment.
Thanks, this is neat and small. Reusing readWorkspaceFile and the existing project.create path is what I'd have hoped for.
I gave it a spin against a dev desktop build and it works nicely. A .code-workspace with a couple of repos opens straight into a multi-root project, and a missing folder gets a clear warning instead of breaking anything. Plain directories still open exactly as before.
One small thing: the palette names a workspace project after the file (platform.code-workspace → "platform"), but this path uses inferProjectTitleFromPath(workspaceRoot). So a file sitting in ~/code gets titled "code". Could we pass the file-derived title through so both entry points agree?
Opening a .code-workspace with t3 app titled the project after the directory holding the file, which is often a generic parent such as ~/code. The command palette already titles it after the file, so share that rule in one helper and use it on both paths.
LoganRupe
pushed a commit
that referenced
this pull request
Sep 18, 2026
`t3 app` now accepts a .code-workspace file as well as a project directory. The CLI sends the file as workspaceFile and its parent as workspaceRoot; the desktop renderer resolves repoRoots through the existing filesystem.readWorkspaceFile query and creates the project the same way the command palette does. Workspace projects opened from the CLI are titled after the file, matching the palette.
LoganRupe
pushed a commit
that referenced
this pull request
Sep 22, 2026
`t3 app` now accepts a .code-workspace file as well as a project directory. The CLI sends the file as workspaceFile and its parent as workspaceRoot; the desktop renderer resolves repoRoots through the existing filesystem.readWorkspaceFile query and creates the project the same way the command palette does. Workspace projects opened from the CLI are titled after the file, matching the palette.
LoganRupe
pushed a commit
that referenced
this pull request
Sep 24, 2026
`t3 app` now accepts a .code-workspace file as well as a project directory. The CLI sends the file as workspaceFile and its parent as workspaceRoot; the desktop renderer resolves repoRoots through the existing filesystem.readWorkspaceFile query and creates the project the same way the command palette does. Workspace projects opened from the CLI are titled after the file, matching the palette.
LoganRupe
pushed a commit
that referenced
this pull request
Sep 26, 2026
`t3 app` now accepts a .code-workspace file as well as a project directory. The CLI sends the file as workspaceFile and its parent as workspaceRoot; the desktop renderer resolves repoRoots through the existing filesystem.readWorkspaceFile query and creates the project the same way the command palette does. Workspace projects opened from the CLI are titled after the file, matching the palette.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
t3 appnow accepts a.code-workspacefile as well as a project directory.The CLI treats that path as
workspaceFileand uses the file’s directory asworkspaceRoot. The desktop renderer reads the file with the existingfilesystem.readWorkspaceFilequery and passesworkspaceFile/repoRootsintoproject.create, the same path the command palette already uses. An existing project at that path is reused.Why
t3 apponly took a directory, so a multi-root workspace could not be opened from the terminal. The server storesworkspaceFileandrepoRootsas given, so the client has to resolve the file before create. That work already exists for the palette; this wires the same inputs through the CLI activation request instead of adding a second create path.