[mfkeeq199458]

Menu, toolbar and panel icons are now loaded through ThemedImages, which picks the *_dark resource variants (images/png/48_dark) when the application runs with the dark color mode, so black glyphs stay visible on dark strips.

Dark-mode defaults were adjusted where fixed colors were still hardcoded: bookmark and auto-bookmark markers, the bookmark/filter 'i'/'!' marker text, LED off/tail states, the ColorComboBox items and the highlight entry preview label.

The change is a pivot from an earlier, never-committed approach that inverted icons at paint time via a custom ToolStrip renderer.

[Hirogen]

Thanks @mfkeeq199458 — switching to proper _dark assets is much better than the paint-time inversion idea, and the dark PNGs look right (same masks, inverted glyphs). Using Application.IsDarkModeEnabled at construction matches the rest of the app and the "restart required" setting, and light mode stays unchanged.

A few things before merging:

Coverage gaps

• LogWindow.cs:535-536: btnFilterDown / btnFilterUp still use Resources.ArrowDown / ArrowUp, even though this PR adds _dark variants for both.
• toolStripButtonTail (LogTabWindow.designer.cs:893) and Pro_Filter (LogWindow.cs:534) stay light-only.

Contrast

• In dark mode the 'i'/'!' marker text (220,130,20) on the new bookmark fill (140,195,240) is about 1.5:1, harder to read than in light mode. Could you pick a darker text or a darker fill?
• LED off (170) and tail-off (175) are almost indistinguishable in dark mode; in light mode they're clearly different (100 vs 160). Please keep a visible gap.

ThemedImages

• (Bitmap)Resources.ResourceManager.GetObject(name) triggers nullable warnings (CS8600/CS8603) and silently returns null on a typo. Please throw (or Debug.Assert) when the resource is missing, so a bad name fails loudly.
• ApplyDarkImages also runs in light mode and replaces the designer-set bitmaps without disposing them. Either only run it when darkMode is true, or rename it to ApplyThemedImages.

Cleanup

• 13 of the 26 _dark PNGs aren't referenced anywhere (Add, ArrowLeft/Right, Bookmarks, Bookmark_added/manager/remove, Check_circle, Deceased, Delete, Favorite, Folder_open, Star). Please drop them, or use the arrows for the filter buttons above.
• HighlightEntryDialog.cs:409-411: please reuse PaintHelper's dark colors (GetForeColorFromHighlightEntry / GetBackColorFromHighlightEntry) instead of hardcoding them. The (32,32,32) background is a no-op anyway, since SystemColors.Window already resolves to it in dark mode.
• ColorComboBox.cs:71: e.ForeColor would be theme- and selection-aware instead of Brushes.White/Black.
• LedIndicatorService.cs: please revert the whitespace-only realignment and the redundant using System.Windows.Forms;.

Description

• The default dark-mode grid text changes from White to (220,220,220) (PaintHelper.cs:107/260/275). That affects every log line, so please mention it in the PR description. I'm fine with the change itself.

Thanks again — this is close!

[Hirogen]

Thanks for the quick turnaround @mfkeeq199458 — almost everything from the last round is in. The new marker text is ~6.2:1 on the bookmark fill and ~6.9:1 on the auto-bookmark fill, the LED gap is clear now, the filter arrows are themed, and ThemedImages.Get throws on a missing resource.

A few small things left:

Build

• ThemedImages.cs:11 and :17 add two CA1304 warnings (ResourceManager.GetObject(string) without a culture). Please pass CultureInfo.CurrentUICulture, or use Resources.Culture to match the generated Resources.Designer.cs.

Leftovers from the previous review

• Pro_Filter (LogWindow.cs:534) is still light-only. A Pro_Filter_dark variant through ThemedImages would finish the set. If that's not feasible, just say so and we can track it separately.
• Please update the PR description. It should mention that the default dark-mode grid text changes from White to (220,220,220), and list the removed assets (the 13 light/dark icon pairs, LogExpert.bmp, LogExpert-Icon.gif, Icon1.ico, Icon2.ico, bubble.ico). I checked: nothing references them, and the installer and ApplicationIcon use logexpert.ico, so the cleanup is fine. It just needs to be visible in the description.

Consistency (small)

• PaintHelper.BookmarkMarkerTextColor reads Application.IsDarkModeEnabled directly, while the bookmark fills take a darkMode parameter. Could it be a method GetBookmarkMarkerTextColor(bool darkMode) like the other PaintHelper APIs? That keeps it testable in PaintHelperTests and stops the text and fill from disagreeing.
• LogWindow.cs:535-537: please read Application.IsDarkModeEnabled once into a local, as :275 already does.
• Optional: in light mode, ApplyThemedImages reloads every bitmap the designer already assigned and doesn't dispose the originals. An early if (!darkMode) return; would avoid that.

FYI, no action needed: a selected ColorComboBox item now draws its text in the highlight colour in light mode too, instead of black. I think that's an improvement. Just noting it because the PR otherwise leaves light mode unchanged.

After the warnings and the description are sorted, this is good to merge from my side. Thanks!