feat(cli): add private rotating host logs - #197
Merged
Merged
Conversation
yashranaway
approved these changes
Sep 19, 2026
yashranaway
left a comment
Collaborator
There was a problem hiding this comment.
Private bounded host logs look right for G2.
The writer is a same-binary helper behind __host-log-writer plus env authorization, not a protocol command. Default destination is the 0700 runtime dir; files are 0600, one link, O_NOFOLLOW, flocked rotation, 1 MiB + one archive. Secret-looking assignments and URL userinfo are redacted before disk. Startup failures only attach an 8 KiB tail that already went through that writer.
HEADLESS_HOST_LOG still has to be absolute and still gets the same file checks. Logging cannot fail open to /dev/null after a bad override: HOST_LOG_UNAVAILABLE fails closed.
CI is green, including Linux E2E.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HEADLESS_HOST_LOGoperator override on macOS and LinuxSecurity
O_NOFOLLOW, ownership checks, and single-link checksValidation
pnpm testpnpm test:runtimepnpm --filter @headless/app buildgit diff --checkThe standard Linux E2E image rebuild was blocked by Docker networking to
deb.debian.org:80; the full suite passed by layering the current build onto the existing provisioned test image. Local macOS E2E passed the new log checks, then hit the existing accessibility HUD flake atstart-page-address-hud; themacos-e2ePR check is requested.Closes #193