Skip to content

Allow tray icons to be precached. - #10

Merged
TheElixZammuto merged 1 commit into
LizardByte:masterfrom
brycerocky:icon_cache
Mar 10, 2024
Merged

TheElixZammuto merged 1 commit into
LizardByte:masterfrom
brycerocky:icon_cache

Conversation

@brycerocky

@brycerocky brycerocky commented Mar 10, 2024 •

Copy link
Copy Markdown

Description

On Windows, loading icons through the shell API can trigger DRM issues, leading to windows becoming invisible. This changelist works around these issues by preloading icons at initialization and avoiding calling the shell API methods on demand.

Screenshot

The change should be transparent to the user. No behav

Issues Fixed or Closed

This brings submodule support for enabling a subsequent change which will resolve this issue.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@CLAassistant

CLAassistant commented Mar 10, 2024 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Comment thread tray_windows.c Outdated
Comment thread tray_windows.c Outdated
On Windows, loading icons through the shell API can trigger DRM issues, leading to windows becoming invisible. This changelist works around these issues by preloading icons at initialization and avoiding calling the shell API methods on demand.
@TheElixZammuto
TheElixZammuto merged commit a08c102 into LizardByte:master Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Madden 24 game window disappears on session resume

4 participants