Repository navigation
Allow tray icons to be precached. - #10
Merged
Merged
Conversation
cgutman
suggested changes
Mar 10, 2024
On Windows, loading icons through the shell API can trigger DRM issues, leading to windows becoming invisible. This changelist works around these issues by preloading icons at initialization and avoiding calling the shell API methods on demand.
cgutman
approved these changes
Mar 10, 2024
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On Windows, loading icons through the shell API can trigger DRM issues, leading to windows becoming invisible. This changelist works around these issues by preloading icons at initialization and avoiding calling the shell API methods on demand.
Screenshot
The change should be transparent to the user. No behav
Issues Fixed or Closed
This brings submodule support for enabling a subsequent change which will resolve this issue.
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.