Sunshine: code sign exe #110

Is there an existing issue for this item?

• I have searched the existing issues

Repositories

LizardByte/Sunshine

Languages/Skills/Technologies

GitHub actions, Windows, Legal/Licensing, packaging

Description

We should start code-signing the exe for Sunshine. This is needed for #109 as well.

References:

• guide: https://www.slicer.org/wiki/Documentation/Nightly/Developers/Windows_Code_Signing#Acquire_and_install_a_code_signing_certificate
• obtain cert: https://learn.microsoft.com/en-us/previous-versions/windows/it-pro/windows-server-2008-R2-and-2008/cc732597(v=ws.10)?redirectedfrom=MSDN
• cmake integration: https://stackoverflow.com/a/72504367/11214013
• github action: https://github.com/marketplace/actions/signtool-code-sign
• cpack post build script: https://stackoverflow.com/a/69230768/11214013

Cost and type of certificate should be examined. From initial investigation it appears there are certificates that are both time and quantity based. e.g. they may only allow a certain number of signings per month, which would not be desirable since we may publish many pre-releases every month. Additionally, the certificate may eventually be used other projects in the LB org. There are also different types, if we want to be able to sign drivers we will need an EV signing certificate, which is only available for official organizations.

Estimated Effort

effort:Medium

Priority

priority:Medium

Target Milestone

1-3 months

Dependencies

No response