Repository navigation
fix(auth): stop logging submitted usernames - #320
Merged
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #320 +/- ##
==========================================
+ Coverage 61.03% 61.05% +0.01%
==========================================
Files 45 45
Lines 13237 13236 -1
==========================================
+ Hits 8079 8081 +2
+ Misses 5158 5155 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the login handler's unconditional stdout message containing the submitted username. Login attempts no longer expose account identifiers through this diagnostic output.
Screenshot
Issues Fixed or Closed
rust/cleartext-logging).Roadmap Issues
Testing
cargo +nightly fmt --checkKOKO_SKIP_FFMPEG_DOWNLOAD=1 cargo test --locked -p koko --test main test_web::routes::auth --jobs 1 -- --test-threads=1(five authentication route tests)git diff --check origin/master...HEADAll checks passed on the rebased commit; 5 authentication route tests passed, 0 failed.
No new regression fixture was added: capturing process-wide stdout would require additional test infrastructure for this one-line diagnostic removal. Manual source review confirms that the username output is removed, and the existing tests cover successful login, wrong passwords, unknown users, logout, and user info. Hosted CodeQL reanalysis is pending.
Type of Change
Checklist
AI Usage
See our AI usage policy.