Repository navigation
feat(notability): Add config for NotabilityChecker for PUBG - #8134
Merged
Merged
Conversation
steve020607
reviewed
Sep 27, 2026
ElectricalBoy
left a comment
ElectricalBoy
left a comment
Collaborator
There was a problem hiding this comment.
should update type annotations (see #8089)
Co-authored-by: ElectricalBoy <15651807+ElectricalBoy@users.noreply.github.com>
Co-authored-by: ElectricalBoy <15651807+ElectricalBoy@users.noreply.github.com>
Rathoz
approved these changes
Oct 2, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The configuration matches the shared checker contract and PUBG tier identifiers without unresolved issues.
Review effort: Balanced
Findings: None
What changed in this PR
Adds PUBG-specific configuration to restore the shared NotabilityChecker.
Changes:
- Defines tier weights, thresholds, and placement limits.
- Adds placement drop-off and mode-adjustment behavior.
| File | Description |
|---|---|
lua/wikis/pubg/NotabilityChecker/config.lua |
Provides the complete PUBG notability configuration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The notability checker on PUBG is not working for some time. The old/non standard config was moved to TemplateArchive and was never replaced. This replaces the config part with a more standard approach that is already on github for multiple other wikis.
See report on Discord