feat(trackmania): MapTable module - #8132
SobakaPirat wants to merge 22 commits into
Conversation
hjpalpha
left a comment
There was a problem hiding this comment.
fwiw Module:MapPoolTable is a module that already exists on the git
maybe it could be extended to be usable by trackmania too (instead of creating a new module)
|
Why use local function for all of it? |
Plus, MapPoolTable looks bad without map images, because of the horizontal scrolling |
I dropped the class related stuff as Hjpa recommended, also it was necessary for splitting the module |
|
Probably for that it should follow under |
| '', | ||
| map = 'https://trackmania.exchange/mapshow/' | ||
| }, | ||
| ['tmio'] = { |
There was a problem hiding this comment.
just an fyi: means we need bot runs on trackmania with merging this
technically could move most into a local table |
Co-authored-by: hjpalpha <75081997+hjpalpha@users.noreply.github.com>
Co-authored-by: hjpalpha <75081997+hjpalpha@users.noreply.github.com>
Co-authored-by: hjpalpha <75081997+hjpalpha@users.noreply.github.com>
|
IIRC the LPDB "maps" field is limited in length, and with this amount of info stored in it you'll run into issues pretty fast. |
it stores into lpdb_datapoint with most of the data going into extradata |
Summary
Сomplete rework of how the maps are shown and how they are stored for Trackmania wiki
The problems this module solves #8120
LPDB
tournament_mapsvariable so they are not overwritten when the module is reinvokedtournament_mapsare stored in themapsfield oftournament_<tournament_name>(the wiki variable set by the infobox, the page title is used as fallback)Tournament information -> Maps
[ { "map": "You shall not pass", "author1": { "flag": "United Kingdom", "page": "Pac", "displayName": "Pac" }, "author2": { "flag": "Germany", "page": "Piranha_(German)", "displayName": "Piranha" }, "author3": { "flag": "Canada", "page": "Carl_Jr.", "displayName": "CarlJr" }, "links": { "trackmania-io": "https://trackmania.io/#/leaderboard/123" "trackmania-exchange": "https://trackmania.exchange/mapshow/321" } }, ]How did you test this change?
https://liquipedia.net/trackmania/User:SobakaPirat/MapTable