Skip to content

refactor(participantTable): extract the input parsing parts - #8118

Open
hjpalpha wants to merge 13 commits into
mainfrom
refactor-partTable-5
Open

refactor(participantTable): extract the input parsing parts#8118
hjpalpha wants to merge 13 commits into
mainfrom
refactor-partTable-5

Conversation

@hjpalpha

@hjpalpha hjpalpha commented Sep 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

prereq:
bot jobs for adjusting ParticipantSection usage (so they are all just jsons instead of using Template.stashArgs)

Summary

  • etract (most) parsing from the old modules into feature structure
  • remove some unused config params
  • move some config defaults into module:info to avoid 4 customs
  • move the import and its parsing to feature structure (have tom combine it with input processing for avoiding complications)

How did you test this change?

test cases and dev
https://liquipedia.net/starcraft2/User:Hjpalpha/wip33

@hjpalpha
hjpalpha added this pull request to stack #8119 September 20, 2026 11:43
@hjpalpha
hjpalpha marked this pull request as ready for review September 20, 2026 12:13
@hjpalpha
hjpalpha requested review from a team as code owners September 20, 2026 12:13
@hjpalpha hjpalpha changed the title refactor(participantTable): extract the parsing parts refactor(participantTable): extract the input parsing parts Sep 20, 2026
@hjpalpha
hjpalpha marked this pull request as draft September 20, 2026 12:34
@hjpalpha

hjpalpha commented Sep 20, 2026

Copy link
Copy Markdown
Collaborator Author

ready for review, but nor for merge (bot job still under way)

@hjpalpha

hjpalpha commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator Author

bot job finished

@hjpalpha
hjpalpha marked this pull request as ready for review September 22, 2026 21:20
ElectricalBoy
ElectricalBoy reviewed Sep 23, 2026
View reviewed changes
Comment thread lua/wikis/commons/Features/ParticipantTable/Lib/ParseImported.lua Outdated
Comment thread lua/wikis/commons/Features/ParticipantTable/Lib/ParseImported.lua Outdated
Comment thread lua/wikis/commons/Features/ParticipantTable/Lib/ParseInput.lua Outdated
Comment thread lua/wikis/commons/Features/ParticipantTable/Lib/ParseImported.lua Outdated
Comment thread lua/wikis/commons/Features/ParticipantTable/Lib/ParseInput.lua Outdated
Comment thread lua/wikis/commons/Features/ParticipantTable/Lib/ParseInput.lua
Comment thread lua/wikis/commons/Features/ParticipantTable/Lib/ParseInput.lua Outdated
Comment thread lua/wikis/commons/Features/ParticipantTable/Lib/Util.lua
@hjpalpha
hjpalpha force-pushed the refactor-partTable-5 branch from 5104782 to a618fc2 Compare September 26, 2026 09:10
Base automatically changed from refactor-partTable-4 to main October 2, 2026 13:59
@Rathoz
Rathoz force-pushed the refactor-partTable-5 branch from a618fc2 to 339e191 Compare October 2, 2026 13:59
Rathoz
Rathoz reviewed Oct 2, 2026
View reviewed changes
Comment thread lua/wikis/commons/Features/ParticipantTable/Lib/ParseInput.lua
Rathoz
Rathoz reviewed Oct 2, 2026
View reviewed changes
Comment thread lua/wikis/commons/Features/ParticipantTable/Lib/ParseInput.lua Outdated
@hjpalpha hjpalpha mentioned this pull request Oct 4, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rathoz Rathoz Awaiting requested review from Rathoz
@ElectricalBoy ElectricalBoy Awaiting requested review from ElectricalBoy

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

c: participant_table

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hjpalpha @Rathoz @ElectricalBoy