Repository navigation
A01: Route table: /agents list, /agents/:id/:tab, redirect old builder URL - #893
Merged
Merged
Conversation
Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
agentTabs.ts(React-free):AGENT_TABS,AgentTab,AGENT_TAB_LABELS,BUILT_AGENT_TABS(onlycanvasbuilt),isAgentTab,agentTabPath, andagentRedirect(legacy/agents/:idand unbuilt/unknown tabs redirect to/agents/:id/canvas, hash query preserved).routeTable.ts:ScreenIdgainsagentList/agentDetail;/agentsis now the agents list,/agents/:id/canvasthe builder,/agents/:id/:tabthe detail route.routes.tsx:useScreenappliesagentRedirectwithreplacebefore the unknown-route fallback;SCREENSgains both entries (rendered insideScreenFrame).AgentListScreen(+ css, EmptyState for an empty workspace) andAgentDetailRoute(returns null until A05).agentRoute.ts:agentRouteIdaccepts all three agent URL shapes;agentPathalways returns the canvas URL;RouteSyncdropscanonical.useAgentRouteSync.ts: unknown id falls back to/agents(the list); follow-the-open-agent navigates to the canvas URL.LeftRailcard click navigates toagentPath(id);CommandPaletteopen agent navigates toagentTabPath(id, 'overview').agentTabs.test.tsandAgentListScreen.test.tsx; e2e specs updated (studio, studioUx, revamp, a11y, narrow, docShots).How it was tested
npm test --workspace apps/agent-forge -- --run: 973 tests pass (90 files).npm run typecheck,npm run lint,npm run typecheck:server,npm run test:server(1121 tests) for apps/agent-forge: pass.npx tsc --noEmit,npm run lint: pass.npm run test:coverage: passes after buildingpackages/create-loushoand normalizing checked-out CRLF template READMEs locally (uncommitted environmental fixes).npm run fallow: clean for this change (3 new contract exports annotated for later tickets); the 6 duplicate-code groups it reports are identical on main.npm run docs:ratchet,npm run api:check,npm run docs:llms:check,npm run size-check: pass.npm run test:e2e:studio: 116 passed; 7 remaining failures are in UI agent-creation flows (server rejects some spec PUTs with validation errors), under investigation — routing, redirects, list fallback, reload persistence and axe scans all pass.Acceptance criteria
#/agentsshows the list placeholder with header "Agents"; the nav item Agents is active.#/agents/<id>lands on#/agents/<id>/canvaswith replace (Back does not return to the legacy URL).#/agents/<id>/canvasopens the builder for that agent; reload keeps it.#/agents/<id>/overview(and any unbuilt or unknown tab) redirects to canvas until that tab's ticket lands.#/agents.#/agents/untitled-agent/canvas.Generated with Devin