tests: Update all components in tests to getter/setter - #4490
Open
BsAtHome wants to merge 1 commit into
Open
Conversation
grandixximo
reviewed
Aug 31, 2026
BsAtHome
force-pushed
the
halgs_fix-tests-components
branch
from
August 31, 2026 10:43
28dff6c to
02e9984
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are components used in the tests. These also need to be converted to getter/setter or the tests will (soon) fail.
This PR addresses that issue. Additionally, several components generated compiler warnings. All of the unused arg/variable/function warnings. These have been quelled by mostly obvious means.