test: improve mutation coverage for certificate validation edge cases - #8065
Merged
vitormattos merged 1 commit intoAug 26, 2026
Merged
Conversation
Signed-off-by: Umair Rathore <umairrathore05@gmail.com>
Member
|
/backport to stable34 |
Member
|
/backport to stable33 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #8053
📝 Summary
Improves mutation-test coverage for
ValidateServiceby adding focused regression cases around certificate field validation boundaries.The added tests cover:
OUmaximum item boundary of 10OUNo production code is changed.
Mutation testing results
The generated-mutant count changed between runs as the additional tests exercised more behavior, so the most relevant comparison is the reduction from 12 to 8 escaped mutants and the Covered Code MSI improvement from 84% to 90%.
The remaining escaped mutants correspond to behavior that is currently non-observable with the existing certificate rules, primarily because
OUis optional (required = false) and hasminItems = 0. I did not add artificial test cases or change mutation configuration solely to increase the score.🧪 How to test
Run the focused PHPUnit tests:
Expected result:
Run Infection against the corresponding source file:
composer mutation:test -- \ lib/Service/Certificate/ValidateService.php \ --test-framework-options="--filter ValidateServiceTest" \ --show-mutations \ --no-progress \ --no-interactionExpected mutation-testing summary:
The focused run generates 80 mutants, with 72 killed and 8 escaped.
⚙️ API / Back-end changes
✅ Checklist
🤖 AI (if applicable)