fix(upload): decode multipart filenames as UTF-8 - #36
Closed
Massimo314 wants to merge 1 commit into
Closed
Conversation
|
|
The /upload and /upload/batch busboy instances omitted defParamCharset, so busboy 1.x used its latin1 default and mangled non-ASCII filenames (e.g. "Расчет_иска.docx" -> "РаÑÑеÑ_иÑка.docx"; also affects Japanese names). Clients send raw UTF-8 filename bytes in Content-Disposition, matching the sibling file-server.ts handler which already sets defParamCharset: 'utf8'. Verified on a production deployment. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Massimo314
force-pushed
the
fix/upload-filename-utf8
branch
from
July 29, 2026 16:33
4c94b92 to
3035592
Compare
Collaborator
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35
Problem
POST /uploadandPOST /upload/batchlose non-ASCII filenames. The namereaches the sandbox
/mnt/dataas UTF-8-bytes-decoded-as-Latin-1 mojibake —e.g.
Расчет_иска.docx→РаÑÑеÑ_иÑка.docx. As noted in #35 thisalso affects Japanese filenames.
Root cause
Both busboy instances in
service/src/service/router.tswere constructedwithout
defParamCharset, so busboy 1.x fell back to itslatin1default anddecoded the multipart
Content-Dispositionfilename bytes as Latin-1. Clients(e.g. LibreChat via
form-data) send the filename as raw UTF-8 bytes, thede-facto browser behavior.
The sibling handler
service/src/file-server.ts(POST /sessions/:id/objects)already sets
defParamCharset: 'utf8'— this change brings the two uploadroutes in line with it.
Fix
Add
defParamCharset: 'utf8'to the/uploadand/upload/batchbusboyoptions.
Verification
the exact mojibake;
defParamCharset: 'utf8'yields the correct name.intact in
/mnt/data.