Flux - Flux as valid MPI runner - #1757
Merged
Merged
Conversation
jlnav
commented
Jul 7, 2026
jlnav
commented
Member
- FLUX_MPIRunner class in the spirit of the others
- Get resource_list from FLUX_URI or cli
- Misc. fomatting as suggested by mypy
- tests
jlnav
marked this pull request as ready for review
July 9, 2026 18:48
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1757 +/- ##
============================================
- Coverage 89.83% 77.08% -12.75%
============================================
Files 79 79
Lines 8340 8413 +73
Branches 1289 1294 +5
============================================
- Hits 7492 6485 -1007
- Misses 648 1671 +1023
- Partials 200 257 +57 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jlnav
force-pushed
the
feature/flux_mpi_runner
branch
3 times, most recently
from
September 10, 2026 14:14
3aadce4 to
1dcb48a
Compare
- Add FLUX_MPIRunner class to mpi_runner.py; registered in the runner factory - Add FluxAllocation platform class to platforms.py; registered in Known_platforms - Add Flux nodelist detection to env_resources.py (get_flux_nodelist, FLUX_URI env var) - Refactor get_slurm_nodelist to call shared get_slurm_nodelist_from_string helper - Add Flux detection (FLUX_URI + flux --version) to get_MPI_variant in mpi_resources.py - Pass nodelist_env_flux through resources.py to EnvResources - Add 'flux' to allowed mpi_runner values in validators.py - Add flux-core installation note to pyproject.toml - Add unit tests for all of the above (test_flux.py) Also apply mypy type annotation fixes to mpi_resources.py (task_partition, get_resources, create_machinefile, get_MPI_runner) required by the updated get_MPI_variant return type (str -> str | None).
jlnav
force-pushed
the
feature/flux_mpi_runner
branch
from
September 10, 2026 14:17
1dcb48a to
0bd0fd1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.