Upgrade actions to Node 24 releases - #26
Conversation
GitHub deprecated Node 20 on Actions runners; checkout@v4, setup-node@v4, and pnpm/action-setup@v4 all target node20 and warn on every run. Bump each to its current major, all of which run on node24: checkout v7, setup-node v7, pnpm/action-setup v6. Checked against our usage: the review workflow triggers on pull_request (not pull_request_target), so checkout v7's fork-PR restriction does not apply; setup-node v7 still supports the explicit `cache: pnpm` input, and package.json has no packageManager field so the v5+ automatic-caching change is a no-op; pnpm/action-setup v6 only adds pnpm 11 support on top of the node24 move in v5. Bumps version to 0.1.18. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Claude finished @cohogan's task in 39s —— View job Code Review: Upgrade actions to Node 24 releases
Looks good. Clean, minimal PR that does exactly what it says. Action bumps — All three actions ( Version bump —
No issues found. The unchanged actions ( | |
Problem
Every workflow run warns:
Change
Bump each to its current major, all of which target node24:
actions/checkoutactions/setup-nodepnpm/action-setupCompatibility, checked against our workflows:
pull_request_target/workflow_runtriggers — our review workflow uses plainpull_request, so unaffected. v6's credential-persistence change and v7's ESM migration don't touch our usage.cache: pnpm+cache-dependency-pathinputs we use. The v5+ automatic-caching feature keys off apackageManagerfield in package.json, which we don't have — no behavior change.version: 10input is unchanged.tauri-apps/tauri-action,dtolnay/rust-toolchain,digicert/ssm-code-signing, andanthropics/claude-code-actionwere not named in the warning and are left as-is.Bumps version to 0.1.18.
The claude-review check on this PR exercises the upgraded checkout; the build workflow only runs on push to main, so the first release build after merge confirms the rest.
Co-Authored-By: Claude Fable 5 noreply@anthropic.com