Repository navigation
[PLT-4664] Raise ResourceNotFoundError when clearing reservations of a missing queue - #2090
Merged
Merged
Conversation
…a missing queue clear_queue_reservations documented ResourceNotFoundError for a queue not in the project, but client.execute returns None on RESOURCE_NOT_FOUND by default, so indexing the result raised TypeError instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Gabefire
requested review from
KahvehS,
KeshavSahoo,
cyrusj89,
john-labelbox,
labelbox-engineering,
lgluszek and
ramy1951
October 21, 2026 14:48
pawelkozik-labelbox
approved these changes
Oct 21, 2026
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2087, fixing the Cursor Bugbot finding that was merged unaddressed.
Project.clear_queue_reservationsdocumentsResourceNotFoundErrorwhen the task queue is not in the project. Butclient.executereturnsNoneon aRESOURCE_NOT_FOUNDGraphQL error unlessraise_return_resource_not_found=Trueis passed, so indexing["clearQueueReservations"]raisedTypeErrorinstead.raise_return_resource_not_found=Truetoexecute, the same asclient.pydoes for its own lookups.Should land before the next SDK release, since #2087 is not in 7.16.0 yet.
🤖 Generated with Claude Code
Note
Low Risk
Narrow error-handling fix for one SDK method with a unit test; no auth, data, or API contract changes beyond matching documented exceptions.
Overview
Project.clear_queue_reservationsnow passesraise_return_resource_not_found=Trueintoclient.execute, so a missing or invalid task queue surfacesResourceNotFoundErroras documented instead of failing with aTypeErrorwhen the client returnsNoneand the code indexesclearQueueReservations.A unit test covers the not-found path and asserts the execute call uses that flag.
Reviewed by Cursor Bugbot for commit 2d6def3. Bugbot is set up for automated code reviews on this repo. Configure here.